On Tue, 27 Aug 2024 at 22:17, Jakub Kicinski kuba@kernel.org wrote:
On Fri, 23 Aug 2024 23:04:50 +0100 Dmitry Safonov via B4 Relay wrote:
First 3 patches are more-or-less cleanups/preparations.
Patches 4/5 are fixes for netns file descriptors leaks/open.
Patch 6 was sent to me/contributed off-list by Mohammad, who wants 32-bit kernels to run TCP-AO.
Patch 7 is a workaround/fix for slow VMs. Albeit, I can't reproduce the issue, but I hope it will fix netdev flakes for connect-deny-* tests.
And the biggest change is adding TCP-AO tracepoints to selftests. I think it's a good addition by the following reasons:
- The related tracepoints are now tested;
- It allows tcp-ao selftests to raise expectations on the kernel behavior - up from the syscalls exit statuses + net counters.
- Provides tracepoints usage samples.
Looks like we got no flakes over the weekend, so applying, thanks! :)
Thanks, Jakub!
I think tcp-ao tests weren't particularly flaky before, but with these patches, those "rarer" flakes should be eliminated now (fingers crossed). To my surprise, I figured out the issue in v3 correctly, which was about the ftracer pthread that didn't have a chance to run during the test. I couldn't reproduce it even once locally. Yet, the newly added xfail with an unexpected tcp_hash_ao_required trace event I'll have to investigate.