Hello Muhammad,
Thanks a lot for your feedback.
On 5/24/22 16:54, Muhammad Usama Anjum wrote:
On 5/24/22 12:36 PM, Javier Martinez Canillas wrote:
diff --git a/tools/testing/selftests/filesystems/fat/Makefile b/tools/testing/selftests/filesystems/fat/Makefile new file mode 100644 index 000000000000..93ee73c16828 --- /dev/null +++ b/tools/testing/selftests/filesystems/fat/Makefile @@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0
+TEST_PROGS := run_fat_tests.sh +TEST_GEN_PROGS_EXTENDED := rename_exchange
Please create a .gitignore file and add rename_exchange to it.
Sorry, you mentioned that in the first revision but I missed.
Yes, I'll do it that on v3.
+CFLAGS += -O2 -g -Wall -I../../../../usr/include/
Build may fail if kernel on which this test is being build has old headers. Always use $(KHDR_INCLUDES) instead of "-I../../../../usr/include/" to use the kernel headers from the kernel source instead of the natively installed headers.
Sure, I'll do that as well.