On Wed, Jul 24, 2024 at 5:28 PM Tony Ambardar tony.ambardar@gmail.com wrote:
Hi Andrii,
On Wed, Jul 24, 2024 at 04:52:57PM -0700, Andrii Nakryiko wrote:
On Mon, Jul 22, 2024 at 10:55 PM Tony Ambardar tony.ambardar@gmail.com wrote:
[...]
Tony Ambardar (19): selftests/bpf: Use pid_t consistently in test_progs.c selftests/bpf: Fix compile error from rlim_t in sk_storage_map.c selftests/bpf: Fix error compiling bpf_iter_setsockopt.c with musl libc selftests/bpf: Drop unneeded include in unpriv_helpers.c selftests/bpf: Drop unneeded include in sk_lookup.c selftests/bpf: Drop unneeded include in flow_dissector.c
I squashed the above three patches into one, as they are the same kind of fix with the same reasoning. The rest at least have a specific error example, so I didn't touch them.
But generally speaking, I think it's fair to combine the same kind of fixes across a few files (for the future).
Thanks for clarifying this and reviewing. My concern earlier was that squashing "Fixes:" tags could hinder backporting. Is that a non-issue?
The fixes are small, so probably not. It's also fixes for selftests, so I'm not even sure how much that matters (for backporting).
Applied to bpf-next, thanks.
And thanks to Geliang Tang, YiFei Zhu, and Vadim Fedorenko for their feedback.
Cheers, Tony Ambardar
[...]