Re: [PATCH v12 13/22] selftests/vm: powerpc implementation for generic abstraction

On 02/21/2018 05:55 PM, Ram Pai wrote:

static inline u32 pkey_to_shift(int pkey) { +#if defined(__i386__) || defined(__x86_64__) /* arch */ return pkey * PKEY_BITS_PER_PKEY; +#elif __powerpc64__ /* arch */

• return (NR_PKEYS - pkey - 1) * PKEY_BITS_PER_PKEY;

+#endif /* arch */ }

I really detest the #if #else style. Can't we just have a pkey_ppc.h and a pkey_x86.h or something? -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html