On Feb 15, 2022, at 10:43 AM, Shuah Khan skhan@linuxfoundation.org wrote:
On 2/15/22 11:17 AM, Muhammad Usama Anjum wrote:
On 2/14/22 9:12 PM, Muhammad Usama Anjum wrote:
"../../../../usr/include/" directory doesn't have header files if different output directory is used for kselftests build like "make -C tools/tests/selftest O=build". Can you try adding recently added variable, KHDR_INCLUDES here which makes this kind of headers inclusion easy and correct for other build combinations as well?
Hi Muhammad,
I just pulled linux-next, and tried with KHDR_INCLUDES. It works. Very nice work! I really appreciate you made headers inclusion compatible. However, my case is a little more complicated. It will throw warnings with -I, using -isystem can suppress these warnings, more details please refer to https://urldefense.com/v3/__https://lore.kernel.org/all/C340461A-6FD2-440A-8... According to this case, do you think will it be better to export header path (KHDR_INCLUDES) without “-I”?
Well said. I've thought about it and it seems like -isystem is better than -I. I've sent a patch: https://urldefense.com/v3/__https://lore.kernel.org/linux-kselftest/20220214... I'm looking forward to discussion on it.
The patch has been accepted. It should appear in linux-next soon. You should be able to use KHDR_INCLUDES easily now.
Sherry,
I pulled in your patch as a fix as is for 5.17-rc5.
Using KHDR_INCLUDES can be separate patch for next release. This way the fix is going to be pulled for this release without dependencies on other patches.
thanks, -- Shuah
Oh, I just sent out v3 patch before I received the updates. Okay, I will send a separate patch with KHDR_INCLUDES later.
Thanks, Sherry