Re: [PATCH v2 6/6] selftests: Test the new RISC-V hwprobe interface

On Mon, Feb 6, 2023 at 1:27 PM Mark Brown broonie@kernel.org wrote:

On Mon, Feb 06, 2023 at 12:14:55PM -0800, Evan Green wrote:

...

+int main(int argc, char **argv) +{

...

--- /dev/null +++ b/tools/testing/selftests/riscv/libc.S

...

+.global _start +_start: +.option push +.option norelax

• la gp, __global_pointer$
  

+.option pop

• la sp, stack
  

• la t0, heap
  

• la t1, brk
  

• REG_S t0, 0(t1)
  

• li a0, 0
  

• li a1, 0
  

• call main
  

This looks like it's just a standard program entry but I don't speak RISC-V asm so I might be missing something. If that's the case might it make sense to use nolibc here?

I think I can just remove this file entirely along with -nostdlib, and just let the compiler add in this glue. -Evan