On Tue, May 5, 2020 at 6:27 PM Anders Roxell anders.roxell@linaro.org wrote:
This makes it easier to enable all KUnit fragments.
Adding 'if !KUNIT_RUN_ALL' so individual test can be turned of if someone wants that even though KUNIT_RUN_ALL is enabled.
nit: Should this be "turned off" rather than "turned of" (and "individual tests" rather than "individual test"). It _may_ be worth re-wording it to explain the "if !KUNIT_RUN_ALL" change in more detail: that it's explicitly hiding the prompt if KUNIT_RUN_ALL is enabled. It's probably not worth redoing the patch just for this, but if you've got to re-do all these to change KUNIT_RUN_ALL to KUNIT_ALL_TESTS or similar, maybe.
Signed-off-by: Anders Roxell anders.roxell@linaro.org
Reviewed-by: David Gow davidgow@google.com
lib/kunit/Kconfig | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/kunit/Kconfig b/lib/kunit/Kconfig index 537f37bc8400..e6a60391fa6b 100644 --- a/lib/kunit/Kconfig +++ b/lib/kunit/Kconfig @@ -15,7 +15,8 @@ menuconfig KUNIT if KUNIT
config KUNIT_DEBUGFS
bool "KUnit - Enable /sys/kernel/debug/kunit debugfs representation"
bool "KUnit - Enable /sys/kernel/debug/kunit debugfs representation" if !KUNIT_RUN_ALLdefault KUNIT_RUN_ALL help Enable debugfs representation for kunit. Currently this consists of /sys/kernel/debug/kunit/<test_suite>/results files for each@@ -23,7 +24,8 @@ config KUNIT_DEBUGFS run that occurred.
config KUNIT_TEST
tristate "KUnit test for KUnit"
tristate "KUnit test for KUnit" if !KUNIT_RUN_ALLdefault KUNIT_RUN_ALL help Enables the unit tests for the KUnit test framework. These tests test the KUnit test framework itself; the tests are both written using@@ -32,7 +34,8 @@ config KUNIT_TEST expected.
config KUNIT_EXAMPLE_TEST
tristate "Example test for KUnit"
tristate "Example test for KUnit" if !KUNIT_RUN_ALLdefault KUNIT_RUN_ALL help Enables an example unit test that illustrates some of the basic features of KUnit. This test only exists to help new users understand-- 2.20.1