On 17/06/21 08:07, Greg KH wrote:
The statistics data itself could be read out by userspace telemetry periodically without any extra parsing or setup effort.
Do you have a pointer to userspace code that can do such a thing that others can use? We do not like adding apis to the kernel without at least seeing the user of those apis, especially for complex things like this.
Ideally you would include some library code in the kernel tree itself that everyone can use for this for their own programs. You have provided a test which is great, but how do we know it works for "real" usages?
I am pretty sure that Google is using this internally, but we are also going to work on QEMU and Libvirt support for this.
As for the rest, thanks for the review---I'll let Jing act on it and only add my own remarks in a couple places.
Paolo