On Wed, 6 Dec 2023 at 02:45, Nikolai Kondrashov Nikolai.Kondrashov@redhat.com wrote:
Introduce a new 'V:' ("Verify") entry to MAINTAINERS. The entry accepts a test suite command which is proposed to be executed for each contribution to the subsystem.
Extend scripts/get_maintainer.pl to support retrieving the V: entries when '--test' option is specified.
Require the entry values to not contain the '@' character, so they could be distinguished from emails (always) output by get_maintainer.pl. Make scripts/checkpatch.pl check that they don't.
Update entry ordering in both scripts/checkpatch.pl and scripts/parse-maintainers.pl.
Signed-off-by: Nikolai Kondrashov Nikolai.Kondrashov@redhat.com
I'm pretty happy with this personally, though I definitely think we need the support for tests which aren't just executable scripts (e.g. the docs in patch 6).
The get_maintailer.pl bits, and hence the requirement to not include '@', feel a little bit 'off': I'd rather get_maintainer.pl kept emails and tests separate by some other means (either having --test _only_ print tests, not emails at all, or by giving them a prefix like 'TEST:' or something). But that is diverging more from the existing behaviour of get_maintainer.pl, so I could go either way.
Otherwise, this looks pretty good. I'll give it a proper test tomorrow alongside the other patches.
Cheers, -- David