Re: [PATCH V5 5/7] cpufreq: amd-pstate: Update amd-pstate preferred core ranking dynamically

On Tue, Sep 05, 2023 at 09:51:14AM +0800, Meng Li wrote:

diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index 446394f84606..2159fd5693fe 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -31,6 +31,11 @@ struct amd_aperf_mperf { u64 mperf; u64 tsc; };

• /* For platforms that do not support the preferred core feature, the

• * highest_pef may be configured with 166 or 255, to avoid max frequency
  

• * calculated wrongly. we take the AMD_CPPC_HIGHEST_PERF(cap1) value as
  

• * the default max perf.
  

• */
  

Invalid comment style, also seems randomly (mis)placed.