On Wed, May 01, 2024 at 06:19:34PM +0100, Conor Dooley wrote:
On Wed, May 01, 2024 at 09:44:15AM -0700, Evan Green wrote:
On Fri, Apr 26, 2024 at 2:29 PM Charlie Jenkins charlie@rivosinc.com wrote:
+struct riscv_isa_vendor_ext_data_list {
const struct riscv_isa_ext_data *ext_data;struct riscv_isainfo *per_hart_vendor_bitmap;unsigned long *vendor_bitmap;It took a lot of digging for me to understand this was the set of vendor extensions supported on all harts. Can we add that to the name, maybe something like isa_bitmap_all_harts? (I wonder if we could drop the vendor part of the name since we already know we're in a vendor_ext_data_list structure).
Reading this made me wonder, why is the all-hart bitmap an unsigned long when the per hart one is a riscv_isainfo struct?
Hmm I don't think there is a good reason for that. I believe this can become struct riscv_isainfo * with no issues.
- Charlie