On Fri, Sep 23, 2022 at 1:01 AM 'David Gow' via KUnit Development kunit-dev@googlegroups.com wrote:
When running a RISC-V test kernel under QEMU, we need an OpenSBI BIOS file. In the original QEMU support patchset, kunit_tool would optionally download this file from GitHub if it didn't exist, using wget.
These days, it can usually be found in the distro's qemu-system-riscv package, and is located in /usr/share/qemu on all the distros I tried (Debian, Arch, OpenSUSE). Use this file, and thereby don't do any downloading in kunit_tool.
In addition, we used to shell out to whatever 'wget' was in the path, which could have potentially been used to trick the developer into running another binary. By not using wget at all, we nicely sidestep this issue.
Cc: Xu Panda xu.panda@zte.com.cn Fixes: 87c9c1631788 ("kunit: tool: add support for QEMU") Reported-by: Zeal Robot zealci@zte.com.cn Signed-off-by: David Gow davidgow@google.com
Reviewed-by: Brendan Higgins brendanhiggins@google.com