Hi, Thomas
On 2023-06-30 07:22:39+0800, Zhangjin Wu wrote:
Willy, Thomas
This is v2 to allow run with minimal kernel config, see v1 [1].
It mainly applied the suggestions from Thomas. It is based on our previous v5 sysret helper series [2] and Thomas' chmod_net removal patchset [3].
Now, a test report on arm/vexpress-a9 without procfs, shmem, tmpfs, net and memfd_create looks like:
LOG: testing report for arm/vexpress-a9: 14 chmod_net [SKIPPED]Shouldn't this be gone?
Yes, if apply your chmod_net removal patches before this series:
LOG: testing report for arm/vexpress-a9:
14 chmod_self [SKIPPED] 16 chown_self [SKIPPED] 40 link_cross [SKIPPED] 0 -fstackprotector not supported [SKIPPED]
139 test(s) passed, 4 skipped, 0 failed. See all results in /labs/linux-lab/logging/nolibc/arm-vexpress-a9-nolibc-test.log
LOG: testing summary:
arch/board | result ------------|------------ arm/vexpress-a9 | 139 test(s) passed, 4 skipped, 0 failed. See all results in /labs/linux-lab/logging/nolibc/arm-vexpress-a9-nolibc-test.log
This test also applied the new proposed chroot_exe and chmod_tmpfile from https://lore.kernel.org/lkml/20230630111433.211130-1-falcon@tinylab.org/
15 chmod_self [SKIPPED] 17 chown_self [SKIPPED] 41 link_cross [SKIPPED] 0 -fstackprotector not supported [SKIPPED] 139 test(s) passed, 5 skipped, 0 failed. See all results in /labs/linux-lab/logging/nolibc/arm-vexpress-a9-nolibc-test.log LOG: testing summary: arch/board | result ------------|------------ arm/vexpress-a9 | 139 test(s) passed, 5 skipped, 0 failed. See all results in /labs/linux-lab/logging/nolibc/arm-vexpress-a9-nolibc-test.log[..]
tools/include/nolibc/sys.h | 22 ++++ tools/testing/selftests/nolibc/nolibc-test.c | 102 +++++++++++++++---- 2 files changed, 106 insertions(+), 18 deletions(-)
A few nitpicks left, mentioned on the patches themselves.
In general: for the full series.
Reviewed-by: Thomas Weißschuh linux@weissschuh.net
Thanks Thomas, will send v3 later.
Best regards, Zhangjin