Re: [PATCH v5 03/14] mm/gup: return an error on migration failure

On Mon, Jan 18, 2021 at 11:39:09PM -0500, Pavel Tatashin wrote:

When migration failure occurs, we still pin pages, which means that we may pin CMA movable pages which should never be the case.

Instead return an error without pinning pages when migration failure happens.

No need to retry migrating, because migrate_pages() already retries 10 times.

Signed-off-by: Pavel Tatashin pasha.tatashin@soleen.com mm/gup.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-)

Reviewed-by: Jason Gunthorpe jgg@nvidia.com