Re: [PATCH v4 2/4] selftests: kvm: s390: Add uc_skey VM test case

On 9/17/24 8:44 AM, Christoph Schlameuss wrote:

Add a test case manipulating s390 storage keys from within the ucontrol VM.

Signed-off-by: Christoph Schlameuss schlameuss@linux.ibm.com

With the nit fixed: Reviewed-by: Janosch Frank frankja@linux.ibm.com

• /* SSKE */
• sync_regs->gprs[1] = skeyvalue;
• run->kvm_dirty_regs |= KVM_SYNC_GPRS;
• ASSERT_EQ(0, uc_run_once(self));
• ASSERT_EQ(false, uc_handle_exit(self));
• ASSERT_EQ(3, sync_regs->gprs[0]);
• ASSERT_EQ(skeyvalue, sync_regs->gprs[1]);
• uc_assert_diag44(self);
• /* RRBE */
• sync_regs->gprs[1] = skeyvalue;
• run->kvm_dirty_regs |= KVM_SYNC_GPRS;
• ASSERT_EQ(0, uc_run_once(self));
• ASSERT_EQ(false, uc_handle_exit(self));
• ASSERT_EQ(4, sync_regs->gprs[0]);
• /* assert R reset but rest of skey unchanged */
• ASSERT_EQ(skeyvalue & 0xfa, sync_regs->gprs[1]);
• ASSERT_EQ(0x00, sync_regs->gprs[1] & 0x04);

s/0x00/0/

• uc_assert_diag44(self);

+}

• TEST_HARNESS_MAIN