28 Jun
2025
28 Jun
'25
12:48 p.m.
On Sat, 28 Jun 2025 14:18:53 +0200 Miguel Ojeda miguel.ojeda.sandonis@gmail.com wrote:
IMO, we should require people to add a comment explaining the reason for adding these lint rules to the codebase. It would make both reading and modifying the code much simpler and clearer.
Do you mean using the lint reasons feature? IIRC we discussed at some point doing that when the feature was added (we enabled it for the `expect` side of things).
Yeah, I meant that it't taking more effort than it should, like digging through historical changes in the relevant parts of the source code, trying to figuring out whether it was just a false positive or if there was a specific reason behind it, etc.