On Tue, 10 Dec 2024 at 20:26, Petr Mladek pmladek@suse.com wrote:
What is the reason to add another set of dependencies, please?
I had done this because not every test required all the options specified in tools/testing/selftests/<test>/config. I thought it would not be desirable to prevent these tests from compiling/running.
Both CONFIG_LIVEPATCH CONFIG_DYNAMIC_DEBUG are already mentioned in tools/testing/selftests/livepatch/config
This particular test only required CONFIG_LIVEPATCH to compile, but I had included CONFIG_DYNAMIC_DEBUG, as Miroslav had expressed wanting both of them checked.
IMHO, the new check should read the dependencies from the existing tools/testing/selftests/<test>/config file.
I shall check tools/testing/selftests/<test>/config in my next patch as suggested.
I run the livepatch tests the following way.
On my workstation, I build the kernel RPMs using
make rpm-pkg
In qemu test system, I mount the build directory from the workstation and install both kernel and kernel-devel packages:
rpm -ivh rpmbuild/RPMS/x86_64/kernel-6.12.0_default+-35.x86_64.rpm rpm -ivh rpmbuild/RPMS/x86_64/kernel-devel-6.12.0_default+-35.x86_64.rpm
and reboot
In rebooted qemu test system, I mount once again the build directory from the workstation and run the tests:
cd tools/testing/selftests/livepatch make run_tests
Thanks, I will test building kernel RPMs when I update the check to be more distro agnostic.
Sincerely, Siddharth Menon