On Fri, Jan 17, 2020 at 11:26 AM Mike Kravetz mike.kravetz@oracle.com wrote:
On 1/14/20 5:26 PM, Mina Almasry wrote:
Augments hugetlb_cgroup_charge_cgroup to be able to charge hugetlb usage or hugetlb reservation counter.
Adds a new interface to uncharge a hugetlb_cgroup counter via hugetlb_cgroup_uncharge_counter.
Integrates the counter with hugetlb_cgroup, via hugetlb_cgroup_init, hugetlb_cgroup_have_usage, and hugetlb_cgroup_css_offline.
Signed-off-by: Mina Almasry almasrymina@google.com
Changes in v10:
- Added missing VM_BUG_ON
Thanks for addressing my comments. I see that patch 8 was updated to address David's comments. I will also review patch 8 later.
I am again requesting that someone with more cgroup experience comment on this patch. I do not have enough experience to determine if the code to not reparent/zombie cgroup is correct.
Thank you very much for your continued reviews and I'm sorry I'm having so much trouble getting anyone with cgroup experience to look deeply into this. My guess is that it's not very active feature and the patchseries is long and complex so folks are not interested. Nevertheless I'm continually poking David and Shakeel and they will hopefully continue to look into this.
FWIW, I have a test for repartenting/counting zombies and the tests at least don't uncover any problems.
For now, Acked-by: Mike Kravetz mike.kravetz@oracle.com while waiting for cgroup comments.
-- Mike Kravetz