Re: [PATCH v11 2/7] KVM: stats: Add fd-based API to read binary stats data

On 18/06/21 08:57, Greg KH wrote:

...

• • 2. Read descriptors from its offset and discover all the stats by parsing
• • descriptors. This is a one-time work for the lifecycle of the
• • corresponding vm/vcpu stats fd.
• • 3. Periodically read stats data from its offset.

You forgot "2.5. rewind fd pointer position", see below...

Or use pread (that's what the test does). I'll do a copy-editing pass and be sure to mention that as well.

Paolo