On 12/12/23 12:00 AM, John Hubbard wrote:
On 12/11/23 03:00, Muhammad Usama Anjum wrote:
On 12/9/23 7:01 AM, John Hubbard wrote:
This reverts commit 9fc96c7c19df ("selftests: error out if kernel header files are not yet built").
I don't think whole of this commit needs to be reverted. Lets leave the warning message as it is and just remove the condition to abort the compilation.
Hi Muhammad!
If we do decide that "make headers" or something like it is required, then yes, this patch should be changed from a revert, to a "warn instead of failing out" patch.
I support this is as most of the times when the latest headers aren't installed in the system. Hence the build of all those kselftests would fail which require the recently added macros. There is no workaround to build those tests until `make headers` is done or the latest headers are installed. The former is easier.
If we just turn this into warning, most people reporting issues with `make headers` would go away. They will be able to build all those kselftest which don't require latest headers. For example mincore kselftest gets build without KHDR_INCLUDES. In case people want to build failing tests, they should add #ifdefs to the tests and submit patches which is idea 4.
First, though, I'd like us to choose a design direction. The patch as written is intended to put us on a design that does not require "make headers" before building the selftests, because that approach would work for all the cases I've seen so far.
If we want something else, then David Hildenbrand has listed several ideas, and I've added a 4th one to the list, in [1].
[1] https://lore.kernel.org/3eadd79c-c02a-495f-92c0-0315046ef59f@nvidia.com
thanks,