Re: [PATCH net v3] selftests: net: local_termination: annotate the expected failures

On Thu, May 16, 2024 at 08:25:13AM -0700, Jakub Kicinski wrote:

Vladimir said when adding this test:

The bridge driver fares particularly badly [...] mainly because it does not implement IFF_UNICAST_FLT.

See commit 90b9566aa5cd ("selftests: forwarding: add a test for local_termination.sh").

We don't want to hide the known gaps, but having a test which always fails prevents us from catching regressions. Report the cases we know may fail as XFAIL.

Signed-off-by: Jakub Kicinski kuba@kernel.org

I agree that XFAIL is appropriate for cases like this - the test is expected to fail and this can act like a TODO.

I also looked over how xfail_on_veth works and this usage seems correct to me.

Reviewed-by: Simon Horman horms@kernel.org