On 9/30/24 02:38, Benjamin Tissoires wrote:
On Sep 29 2024, Yun Lu wrote:
The HID test cases actually run tests using the run-hid-tools-tests.sh script. However, if installed with "make install", the run-hid-tools-tests.sh script will not be copied over, resulting in the following error message.
make -C tools/testing/selftests/ TARGETS=hid install \ INSTALL_PATH=$KSFT_INSTALL_PATH
cd $KSFT_INSTALL_PATH ./run_kselftest.sh -c hid
selftests: hid: hid-core.sh bash: ./run-hid-tools-tests.sh: No such file or directory
So add the run-hid-tools-tests.sh script to the TEST_FILES in the Makefile.
I assume we probably also want:
Cc: stable@vger.kernel.org
Signed-off-by: Yun Lu luyun@kylinos.cn
Not sure about the timing regarding our next PR to Linus, so in any cases:
Acked-by: Benjamin Tissoires bentiss@kernel.org
Thank you. This commit appears to be right one for Fixes tag?
Is this the right commit for Fixes tag:
Fixes: commit ffb85d5c9e80 ("selftests: hid: import hid-tools hid-core tests")
Will apply with this tag added to linux-kselftest fixes for next rc once I get conformation.
thanks, -- Shuah