Re: [RFC PATCH v4 1/2] selftests/x86: sysret_rip: Handle syscall in a FRED system

On Wed, Jan 25, 2023 at 10:37:17AM +0700, Ammar Faizi wrote:

On Wed, Jan 25, 2023 at 10:22:39AM +0700, Ammar Faizi wrote:

...

• /*

• * Test that we don't get a mix of REGS_SAVED and REGS_SYSRET.
  

• * It needs at least calling do_syscall() twice to assert.
  

• */
  

• if (regs_ok_state == REGS_UNDEFINED) {

• /*
  

•  * First time calling do_syscall().
  

•  */
  

• regs_ok_state = ret;
  

• return ret;
  

• } else {

Oops, this should not be returning ret here. Ignore this version. I'll send v5.

Side note: This mistake doesn't affect the test correctness because we currenly don't use the return value of do_syscall().

But still worth fixing...