On 7/31/23 09:54, Ido Schimmel wrote:
Thanks for testing.
Not at all.
On Sun, Jul 30, 2023 at 06:48:04PM +0200, Mirsad Todorovac wrote:
not ok 26 selftests: net/forwarding: ip6_forward_instats_vrf.sh # exit=1
Regarding this one, in the log I don't see the require_command() that I added in "selftests: forwarding: Set default IPv6 traceroute utility". Also, at line 470 I see "ip vrf exec vveth0 2001:1:2::2" which is another indication that you don't have the patch.
This is correct.
Now I have:
root@defiant:tools/testing/selftests/net/forwarding# ./ip6_forward_instats_vrf.sh SKIP: traceroute6 not installed
Mystery solved. This is much more useful output :-)
Installed traceroute6 and now the test is OK:
root@defiant:tools/testing/selftests/net/forwarding# ./ip6_forward_instats_vrf.sh TEST: ping6 [ OK ] TEST: Ip6InTooBigErrors [ OK ] TEST: Ip6InHdrErrors [ OK ] TEST: Ip6InAddrErrors [ OK ] TEST: Ip6InDiscards [ OK ] root@defiant:tools/testing/selftests/net/forwarding#
I guess that means only three are left.
# ./bridge_mdb.sh dev br0 port veth1 grp 239.1.1.1 src 192.0.2.1 temp filter_mode include proto static vid 10 259.99 TEST: IPv4 (S, G) port group entries configuration tests [FAIL] Entry has an unpending group timer after replace dev br0 port veth1 grp ff0e::1 src 2001:db8:1::1 temp filter_mode include proto static vid 10 259.99 TEST: IPv6 (S, G) port group entries configuration tests [FAIL] Entry has an unpending group timer after replace # ./bridge_vlan_mcast.sh TEST: Vlan mcast_startup_query_interval global option default value [FAIL] Wrong default mcast_startup_query_interval global vlan option value # ./mirror_gre_changes.sh TEST: mirror to gretap: TTL change (skip_hw) [FAIL] Expected to capture 10 packets, got 15. TEST: mirror to ip6gretap: TTL change (skip_hw) [FAIL] Expected to capture 10 packets, got 13. WARN: Could not test offloaded functionality #
NOTE: The error happened because two patches collided. This patch
diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh index 975fc5168c6334..40a8c1541b7f81 100755 --- a/tools/testing/selftests/net/forwarding/lib.sh +++ b/tools/testing/selftests/net/forwarding/lib.sh @@ -30,6 +30,7 @@ REQUIRE_MZ=${REQUIRE_MZ:=yes} REQUIRE_MTOOLS=${REQUIRE_MTOOLS:=no} STABLE_MAC_ADDRS=${STABLE_MAC_ADDRS:=no} TCPDUMP_EXTRA_FLAGS=${TCPDUMP_EXTRA_FLAGS:=} +TROUTE6=${TROUTE6:=traceroute6}
relative_path="${BASH_SOURCE%/*}" if [[ "$relative_path" == "${BASH_SOURCE}" ]]; then
and this patch
diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh index 71f7c0c49677..5b0183013017 100755 --- a/tools/testing/selftests/net/forwarding/lib.sh +++ b/tools/testing/selftests/net/forwarding/lib.sh @@ -16,8 +16,6 @@ TEAMD=${TEAMD:=teamd} WAIT_TIME=${WAIT_TIME:=5} PAUSE_ON_FAIL=${PAUSE_ON_FAIL:=no} PAUSE_ON_CLEANUP=${PAUSE_ON_CLEANUP:=no} -NETIF_TYPE=${NETIF_TYPE:=veth} -NETIF_CREATE=${NETIF_CREATE:=yes} MCD=${MCD:=smcrouted} MC_CLI=${MC_CLI:=smcroutectl} PING_COUNT=${PING_COUNT:=10} @@ -30,6 +28,20 @@ REQUIRE_MZ=${REQUIRE_MZ:=yes} REQUIRE_MTOOLS=${REQUIRE_MTOOLS:=no} STABLE_MAC_ADDRS=${STABLE_MAC_ADDRS:=no} TCPDUMP_EXTRA_FLAGS=${TCPDUMP_EXTRA_FLAGS:=} +NETIF_TYPE=${NETIF_TYPE:=veth} +NETIF_CREATE=${NETIF_CREATE:=yes} +declare -A NETIFS=( + [p1]=veth0 + [p2]=veth1 + [p3]=veth2 + [p4]=veth3 + [p5]=veth4 + [p6]=veth5 + [p7]=veth6 + [p8]=veth7 + [p9]=veth8 + [p10]=veth9 +)
relative_path="${BASH_SOURCE%/*}" if [[ "$relative_path" == "${BASH_SOURCE}" ]]; then
are not compatible.
I have applied the 'require_command $TROUTE6' patch manually.
I suppose this is what you intended to have:
# Can be overridden by the configuration file. PING=${PING:=ping} PING6=${PING6:=ping6} MZ=${MZ:=mausezahn} ARPING=${ARPING:=arping} TEAMD=${TEAMD:=teamd} WAIT_TIME=${WAIT_TIME:=5} PAUSE_ON_FAIL=${PAUSE_ON_FAIL:=no} PAUSE_ON_CLEANUP=${PAUSE_ON_CLEANUP:=no} MCD=${MCD:=smcrouted} MC_CLI=${MC_CLI:=smcroutectl} PING_COUNT=${PING_COUNT:=10} PING_TIMEOUT=${PING_TIMEOUT:=5} WAIT_TIMEOUT=${WAIT_TIMEOUT:=20} INTERFACE_TIMEOUT=${INTERFACE_TIMEOUT:=600} LOW_AGEING_TIME=${LOW_AGEING_TIME:=1000} REQUIRE_JQ=${REQUIRE_JQ:=yes} REQUIRE_MZ=${REQUIRE_MZ:=yes} REQUIRE_MTOOLS=${REQUIRE_MTOOLS:=no} STABLE_MAC_ADDRS=${STABLE_MAC_ADDRS:=no} TCPDUMP_EXTRA_FLAGS=${TCPDUMP_EXTRA_FLAGS:=} TROUTE6=${TROUTE6:=traceroute6} NETIF_TYPE=${NETIF_TYPE:=veth} NETIF_CREATE=${NETIF_CREATE:=yes} declare -A NETIFS=( [p1]=veth0 [p2]=veth1 [p3]=veth2 [p4]=veth3 [p5]=veth4 [p6]=veth5 [p7]=veth6 [p8]=veth7 [p9]=veth8 [p10]=veth9 )
relative_path="${BASH_SOURCE%/*}" if [[ "$relative_path" == "${BASH_SOURCE}" ]]; then relative_path="." fi ------------------------------------------------
Probably for the production patch you would like to have this fixed.
Have a nice day.
Kind regards, Mirsad