On Sat, Jul 13, 2024 at 09:35:36AM +0200, Jaroslav Kysela wrote:
On 12. 07. 24 20:19, Mark Brown wrote:
Sure, but the genesis of this patch is that probe order isn't sufficiently stable and we want to avoid names based on it... using the ID will be more likely to work out stable than just pure probe order but it's still got the same issue.
The probe order is almost stable for the drivers with the non-deferred probe. Also, administrators may set persistent ID for complex hardware
It's not very stable for modules being loaded, there's enough going on and enough module loads happening simultaneously that it's very easy for drivers to come up in different orders. I'm seeing these issues quite frequently in my test farm.
configuration cases based on other keys like serial number or so (sysfs/udev).
For a lot of test scenarios that's just not really relevant - with a pool of machines any per machine keys get hard to manage, and for something like kernelci.org customising the rootfs for even classes of boards never mind specific boards is going to be an unreasonable ask.
For long name - the device path may change (USB moved to different port, PCI card moved to different slot), so the stability of this string is also questionable.
The concern here is repeated boots on the same system in an automated context, if someone changes the hardware then it's reasonable that the set of cards would change.