Re: [net-next v1 08/16] memory-provider: dmabuf devmem memory provider

On Thu, Dec 07, 2023 at 04:52:39PM -0800, Mina Almasry wrote:

+static inline struct page_pool_iov *page_to_page_pool_iov(struct page *page) +{

• if (page_is_page_pool_iov(page))

• return (struct page_pool_iov *)((unsigned long)page & ~PP_IOV);
  

• DEBUG_NET_WARN_ON_ONCE(true);
• return NULL;

+}

We already asked not to do this, please do not allocate weird things can call them 'struct page' when they are not. It undermines the maintainability of the mm to have things mis-typed like this. Introduce a new type for your thing so the compiler can check it properly.

Jason