Re: [PATCH v8 1/5] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso'

On 6/10/21 1:30 AM, Jarkko Sakkinen wrote:

Rename symbols for better clarity:

• 'eenter' might be confused for directly calling ENCLU[EENTER]. It does not. It calls into the VDSO, which actually has the EENTER instruction.
• 'sgx_call_vdso' is *only* used for entering the enclave. It's not some generic SGX call into the VDSO.

Signed-off-by: Jarkko Sakkinen jarkko@kernel.org

These all look fine to me. Feel free to add my ack on them.

Since these are pure x86 selftests and the initial code went through the x86 maintainers, should these got through them as well? Or, since this is only selftest code, should Shuah pick them up?