On Sun, 2025-12-28 at 08:47 +0300, Askar Safin wrote:
"Nícolas F. R. A. Prado" nfraprado@collabora.com:
Add a sample board file describing the file's format and with the list of devices expected to be probed on the XPS 13 9300 machine as an example x86 platform.
And now "Dell Inc.,XPS 13 9300.yaml" became the only file in the repository, which has space in its name:
$ find . -name '* *' ./tools/testing/selftests/devices/probe/boards/Dell Inc.,XPS 13 9300.yaml
I kindly ask you to rename file. New name should not contain space or comma in it.
While I understand it might be inconvenient that this is the only file with a space in its name, that is exactly the string that is reported by DMI, so it is natural that it would be used for the filename.
Besides, I'm not aware of there being a style guide rule that prohibits space in filenames in the kernel tree, or that could have easily be detected by checkpatch during submission.
Furthermore, not containing a comma is not even feasible, there are tons of dt-binding filenames containing commas in the tree.
The file name in its current form breaks tools. For example, it breaks "xargs".
For example, the following will work in "fs" directory:
stable/fs$ find . | xargs chmod -w
But it will not work in root of source tree because of this "Dell Inc.,XPS 13 9300.yaml" file:
stable$ find . | xargs chmod -w chmod: cannot access './tools/testing/selftests/devices/probe/boards/Dell': No such file or directory chmod: cannot access 'Inc.,XPS': No such file or directory chmod: cannot access '13': No such file or directory chmod: cannot access '9300.yaml': No such file or directory
You can use 'find -print0' and 'xargs -0' instead so the space in the filename is not an issue.