Re: [PATCH v12 2/9] hugetlb_cgroup: add interface for charge/uncharge hugetlb reservations

On 2/11/20 1:31 PM, Mina Almasry wrote:

Augments hugetlb_cgroup_charge_cgroup to be able to charge hugetlb usage or hugetlb reservation counter.

Adds a new interface to uncharge a hugetlb_cgroup counter via hugetlb_cgroup_uncharge_counter.

Integrates the counter with hugetlb_cgroup, via hugetlb_cgroup_init, hugetlb_cgroup_have_usage, and hugetlb_cgroup_css_offline.

Signed-off-by: Mina Almasry almasrymina@google.com

Thanks for the suggested changes. It will make the code easier to read and understand.

Acked-by: Mike Kravetz <mike.kravetz@oracle.com

---

Changes in v12:

• Instead of true/false param for rsvd or non-rsvd calls, now there is:

hugetlb_cgroup_*() call for non-rsvd hugetlb_cgroup_*_rsvd() call for rsvd __hugetlb_cgroup_*(, bool) for both.

• Removed review tags as this patch changed quite a bit.