Re: [PATCH net-next 1/4] selftests: forwarding: Test redirecting gre or ipip packets to Ethernet

On 7/6/21 1:02 PM, Guillaume Nault wrote:

--- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -3767,8 +3767,7 @@ static int vxlan_config_validate(struct net *src_net, struct vxlan_config *conf, (conf->flags & (VXLAN_F_RCV_FLAGS | VXLAN_F_IPV6))) continue;

• if ((conf->flags & VXLAN_F_IPV6_LINKLOCAL) &&
  

•     tmp->cfg.remote_ifindex != conf->remote_ifindex)
  

• if (tmp->cfg.remote_ifindex != conf->remote_ifindex)
  continue;
  

NL_SET_ERR_MSG(extack,

Looking at the vxlan driver and that restriction is unnecessary. While IPv6 LLA requires a device index, allowing separate LINK attributes is a legit use case - as VRF shows.

Do you want to send a formal patch to fix this one since you have it diagnosed?