28 Nov
2025
28 Nov
'25
6:40 p.m.
On Fri, 28 Nov 2025 11:34:38 +0100 Matthieu Baerts wrote:
Including kselftest.h will be needed.
Because mptcp_connect.c is a tool that is used by other selftests, but it doesn't interact directly with the selftests, maybe we don't need to include it, and only add this #define in mptcp_connect.c?
#define __noreturn __attribute__((__noreturn__))
Up to you, I'd be worried that some semi-automated patch generator will send us a "cleanup" to remove this as duplication. But I'm overly sensitive to this sort of followups so we can try if you prefer :)