Re: [PATCH] selftests: timers: rtcpie: skip test if default RTC device does not exist

On 5/24/21 8:36 PM, Po-Hsu Lin wrote:

This test will require /dev/rtc0, the default RTC device, or one specified by user to run. Since this default RTC is not guaranteed to exist on all of the devices, so check its existence first, otherwise skip this test with the kselftest skip code 4.

Without this patch this test will fail like this on a s390x zVM: # selftests: timers: rtcpie # /dev/rtc0: No such file or directory not ok 1 selftests: timers: rtcpie # exit=22

With this patch: # selftests: timers: rtcpie # Default RTC /dev/rtc0 does not exist. Test Skipped! not ok 9 selftests: timers: rtcpie # SKIP

Signed-off-by: Po-Hsu Lin po-hsu.lin@canonical.com

Thank you for the patch. Will pick this up for 5.14

thanks, -- Shuah