Re: [PATCH v3 14/15] iommufd: vfio container FD ioctl compatibility

On Tue, Oct 25, 2022 at 03:12:23PM -0300, Jason Gunthorpe wrote:

+static int iommufd_vfio_iommu_get_info(struct iommufd_ctx *ictx,

• 		       void __user *arg)
  

• if (copy_to_user(arg, &info, minsz))

• rc = -EFAULT;
  

• rc = 0;

Coverity reports a value overwriting here: rc gets -EFAULT first then gets overwritten to 0.

+out_put:

• up_read(&ioas->iopt.iova_rwsem);
• iommufd_put_object(&ioas->obj);
• return rc;

+}