Re: [PATCH bpf v1 1/2] bpf: fix link info netfilter flags to populate defrag flag

On 10/15/24 5:25 PM, Florian Westphal wrote:

Tyrone Wu wudevelops@gmail.com wrote:

...

This patch correctly populates the `bpf_link_info.netfilter.flags` field when user passes the `BPF_F_NETFILTER_IP_DEFRAG` flag.

Indeed, thanks for fixing this. Patch and testcase look good, but one nit:

...

Fixes: 84601d6ee68a ("bpf: add bpf_link support for BPF_NETFILTER programs")

BPF_F_NETFILTER_IP_DEFRAG flag was added in 91721c2d02d3 ("netfilter: bpf: Support BPF_F_NETFILTER_IP_DEFRAG in netfilter link"), that was a bit later than the initial support.

Other than that, Acked-by: Florian Westphal fw@strlen.de

Thanks Florian & Tyrone, fixed up Fixes tag while applying.