14 Mar
2025
14 Mar
'25
1:04 p.m.
On Fri 2025-03-07 06:27:38, Tamir Duberstein wrote:
Remove the unused `kernel.h`. Replace `string.h` with `sprintf.h` as the former doesn't seem to be used directly.
--- a/lib/tests/scanf_kunit.c +++ b/lib/tests/scanf_kunit.c @@ -5,12 +5,11 @@ #include <kunit/test.h> #include <linux/bitops.h> -#include <linux/kernel.h> #include <linux/module.h> #include <linux/overflow.h> #include <linux/prandom.h> #include <linux/slab.h> -#include <linux/string.h> +#include <linux/sprintf.h> #define BUF_SIZE 1024
The change makes sense and looks good to me. I would go with it.
Reviewed-by: Petr Mladek pmladek@suse.com Tested-by: Petr Mladek pmladek@suse.com
Further improvements might be done later in a separate patchset...
Best Regards, Petr