Re: [PATCH net-next v10 05/14] netdev: netdevice devmem allocator

On Tue, 04 Jun 2024 12:13:15 +0200 Paolo Abeni pabeni@redhat.com wrote:

On Thu, 2024-05-30 at 20:16 +0000, Mina Almasry wrote:

...

diff --git a/net/core/devmem.c b/net/core/devmem.c index d82f92d7cf9ce..d5fac8edf621d 100644 --- a/net/core/devmem.c +++ b/net/core/devmem.c @@ -32,6 +32,14 @@ static void net_devmem_dmabuf_free_chunk_owner(struct gen_pool *genpool, kfree(owner); } +static inline dma_addr_t net_devmem_get_dma_addr(const struct net_iov *niov)

Minor nit: please no 'inline' keyword in c files.

I'm curious. Is this a networking rule? I use 'inline' in my C code all the time.

-- Steve