Re: [PATCH v6 01/18] kunit: test: add KUnit test runner core

On Fri, Jul 5, 2019 at 1:20 PM Luis Chamberlain mcgrof@kernel.org wrote:

On Wed, Jul 03, 2019 at 05:35:58PM -0700, Brendan Higgins wrote:

...

+struct kunit {

• void *priv;
  

• /* private: internal use only. */
  

• const char *name; /* Read only after initialization! */
  

• bool success; /* Read only after test_case finishes! */
  

+};

No lock attribute above.

...

+void kunit_init_test(struct kunit *test, const char *name) +{

• spin_lock_init(&test->lock);
  

• test->name = name;
  

• test->success = true;
  

+}

And yet here you initialize a spin lock... This won't compile. Seems you forgot to remove this line. So I guess a re-spin is better.

Oh crap, sorry about that. You can't compile these patches until the kbuild patch. I will fix this and make sure I didn't make any similar mistakes on these early patches.

Thanks!