16 May
2025
16 May
'25
2:35 p.m.
On Thu, 15 May 2025 16:13:32 -0700 Stanislav Fomichev wrote:
Cover three recent cases:
- missing ops locking for the lowers during netdev_sync_lower_features
- missing locking for dev_set_promiscuity (plus netdev_ops_assert_locked with a comment on why/when it's needed)
- rcu lock during team_change_rx_flags
Verified that each one triggers when the respective fix is reverted. Not sure about the placement, but since it all relies on teaming, added to the teaming directory.
One ugly bit is that I add NETIF_F_LRO to netdevsim; there is no way to trigger netdev_sync_lower_features without it.
Seems to consistently fail in NIPA :(
--
pw-bot: cr