Re: [PATCH] selftests/vm: Add protection_keys tests to run_vmtests

On 6/1/2022 12:10 AM, Andrew Morton wrote:

On Tue, 31 May 2022 15:55:56 +0530 Kalpana Shetty kalpana.shetty@amd.com wrote:

...

--- a/tools/testing/selftests/vm/run_vmtests.sh +++ b/tools/testing/selftests/vm/run_vmtests.sh @@ -179,4 +179,11 @@ run_test ./ksm_tests -N -m 1 # KSM test with 2 NUMA nodes and merge_across_nodes = 0 run_test ./ksm_tests -N -m 0 +# protection_keys tests +if [ $VADDR64 -eq 0 ]; then

• run_test ./protection_keys_32

+else

• run_test ./protection_keys_64

+fi

• exit $exitcode

So we're presently not running this test at all, unless invoked by hand?

Yes.

I'm thinking we should backport this fix - have you any idea when we broke it?

We didn't break it, just adding "protection_keys" test as part of run_vmtests.sh

Thanks,

Kalpana