On Fri, 10 Dec 2021, Jakub Kicinski wrote:
On Fri, 10 Dec 2021 16:36:06 +0100 Matthieu Baerts wrote:
Actually, I take that back, let's hear from Mat, he may want to take the patch via his tree.
We "rebase" our tree on top of net-next every night. I think for such small patches with no behaviour change and sent directly to netdev ML, it is probably best to apply them directly. I can check with Mat if it is an issue if you prefer.
Please do, I'm happy to apply the patch but Mat usually prefers to take things thru MPTCP tree.
Jakub -
It is ok with me if you apply this now, for the reasons Matthieu cited.
The usual division of labor between Matthieu and I as MPTCP co-maintainers usually has me upstreaming the patches to netdev, but I do trust Matthieu's judgement on sending out Reviewed-by tags and advising direct appliction to the netdev trees! Also, much like you & David, having offset timezones can be helpful.
Also appreciate your awareness of the normal patch flow for MPTCP, and that you're checking that we're all on the same page.
I would have applied it in our MPTCP tree if we were sending PR, not to bother you for such patches but I guess it is best not to have us sending this patch a second time later :)
BTW, if you prefer us sending PR over batches of patches, please tell us!
Small preference for patches. It's good to have the code on the ML for everyone to look at and mixed PR + patches are a tiny bit more clicking for me.
Good to know.
Thanks!
-- Mat Martineau Intel