Re: [PATCH v2 1/2] open: add close_range()

On Thu, May 23, 2019 at 06:20:05PM +0200, Oleg Nesterov wrote:

On 05/23, Christian Brauner wrote:

...

+int __close_range(struct files_struct *files, unsigned fd, unsigned max_fd) +{

• unsigned int cur_max;
• if (fd > max_fd)

• return -EINVAL;
  

• rcu_read_lock();
• cur_max = files_fdtable(files)->max_fds;
• rcu_read_unlock();
• /* cap to last valid index into fdtable */
• max_fd = max(max_fd, (cur_max - 1));

             ^^^

Hmm. min() ?

Yes, thanks! Massive brainf*rt on my end, sorry.

Christian