On 2/14/22 9:12 PM, Muhammad Usama Anjum wrote:
"../../../../usr/include/" directory doesn't have header files if different output directory is used for kselftests build like "make -C tools/tests/selftest O=build". Can you try adding recently added variable, KHDR_INCLUDES here which makes this kind of headers inclusion easy and correct for other build combinations as well?
Hi Muhammad,
I just pulled linux-next, and tried with KHDR_INCLUDES. It works. Very nice work! I really appreciate you made headers inclusion compatible. However, my case is a little more complicated. It will throw warnings with -I, using -isystem can suppress these warnings, more details please refer to https://lore.kernel.org/all/C340461A-6FD2-440A-8EFC-D7E85BF48DB5@oracle.com/
According to this case, do you think will it be better to export header path (KHDR_INCLUDES) without “-I”?
Well said. I've thought about it and it seems like -isystem is better than -I. I've sent a patch: https://lore.kernel.org/linux-kselftest/20220214160756.3543590-1-usama.anjum... I'm looking forward to discussion on it.
The patch has been accepted. It should appear in linux-next soon. You should be able to use KHDR_INCLUDES easily now.
Thanks, Usama