Re: [PATCH] selftests net/socket.c: removed warnings from unused returns

Thanks for the review! I'll send the patch v2 with the adjustments shortly.

On Mon, Aug 18, 2025 at 5:35 PM Jakub Kicinski kuba@kernel.org wrote:

On Thu, 14 Aug 2025 23:06:31 -0700 Alex Tran wrote:

...

• char *err_message1;
  

• char *err_message2;
  

nit, how about:

    const char *msg1, *msg2;

? And then please wrap the lines at 80 chars.

...

  int i, err;

  err = 0;

@@ -56,13 +58,13 @@ static int run_tests(void) errno == -s->expect) continue;

•                 strerror_r(-s->expect, err_string1, ERR_STRING_SZ);
  

•                 strerror_r(errno, err_string2, ERR_STRING_SZ);
  

•                 err_message1 = strerror_r(-s->expect, err_string1, ERR_STRING_SZ);
  

•                 err_message2 = strerror_r(errno, err_string2, ERR_STRING_SZ);