Re: [PATCH bpf-next] selftests: bpf: use MIN for TCP CC tests

Hi Geliang,

On 4/7/22 6:19 AM, Geliang Tang wrote:

Use macro MIN() in sys/param.h for TCP CC tests, instead of defining a new one.

Signed-off-by: Geliang Tang geliang.tang@suse.com

Thanks for your cleanup; we do seem to have this in a bunch of places:

tools/testing/selftests/bpf/prog_tests/bpf_iter.c:1195:#define min(a, b) ((a) < (b) ? (a) : (b)) tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c:13:#define min(a, b) ((a) < (b) ? (a) : (b)) tools/testing/selftests/bpf/prog_tests/snprintf.c:86:#define min(a, b) ((a) < (b) ? (a) : (b))

Mind sending a v2 which cleans up all at once to reduce too much churn?

Thanks, Daniel