[PATCH net-next v6 7/8] net: pktgen: remove all superfluous index assignements

21 Feb 2025

Remove all superfluous index ('i += len') assignements (value not used
afterwards).
Signed-off-by: Peter Seiderer ps.report@gmx.net
Reviewed-by: Simon Horman horms@kernel.org
---
Changes v5 -> v6
  - add rev-by Simon Horman
Changes v4 -> v5
  - new patch (suggested by Simon Horman)
---
 net/core/pktgen.c | 52 ++++++-----------------------------------------
 1 file changed, 6 insertions(+), 46 deletions(-)

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index bb13a4591709..96511e57c3fb 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -1030,7 +1030,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (value < 14 + 20 + 8)
    		value = 14 + 20 + 8;
    	if (value != pkt_dev->min_pkt_size) {
@@ -1048,7 +1047,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (value < 14 + 20 + 8)
    		value = 14 + 20 + 8;
    	if (value != pkt_dev->max_pkt_size) {
@@ -1068,7 +1066,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (value < 14 + 20 + 8)
    		value = 14 + 20 + 8;
    	if (value != pkt_dev->min_pkt_size) {
@@ -1091,7 +1088,6 @@ static ssize_t pktgen_if_write(struct file *file,
fill_imix_distribution(pkt_dev);
-		i += len;
    	return count;
    }
@@ -1101,7 +1097,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	debug = value;
    	sprintf(pg_result, "OK: debug=%u", debug);
    	return count;
@@ -1113,7 +1108,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	pkt_dev->nfrags = value;
    	sprintf(pg_result, "OK: frags=%d", pkt_dev->nfrags);
    	return count;
@@ -1124,7 +1118,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (value == 0x7FFFFFFF)
    		pkt_dev->delay = ULLONG_MAX;
    	else
@@ -1140,7 +1133,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (!value)
    		return -EINVAL;
    	pkt_dev->delay = pkt_dev->min_pkt_size*8*NSEC_PER_USEC/value;
@@ -1156,7 +1148,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (!value)
    		return -EINVAL;
    	pkt_dev->delay = NSEC_PER_SEC/value;
@@ -1172,7 +1163,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (value != pkt_dev->udp_src_min) {
    		pkt_dev->udp_src_min = value;
    		pkt_dev->cur_udp_src = value;
@@ -1186,7 +1176,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (value != pkt_dev->udp_dst_min) {
    		pkt_dev->udp_dst_min = value;
    		pkt_dev->cur_udp_dst = value;
@@ -1200,7 +1189,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (value != pkt_dev->udp_src_max) {
    		pkt_dev->udp_src_max = value;
    		pkt_dev->cur_udp_src = value;
@@ -1214,7 +1202,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (value != pkt_dev->udp_dst_max) {
    		pkt_dev->udp_dst_max = value;
    		pkt_dev->cur_udp_dst = value;
@@ -1238,7 +1225,6 @@ static ssize_t pktgen_if_write(struct file *file,
    			  !(pkt_dev->flags & F_SHARED)))
    		return -EINVAL;
-		i += len;
    	pkt_dev->clone_skb = value;
sprintf(pg_result, "OK: clone_skb=%d", pkt_dev->clone_skb);
@@ -1250,7 +1236,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	pkt_dev->count = value;
    	sprintf(pg_result, "OK: count=%llu",
    		(unsigned long long)pkt_dev->count);
@@ -1262,7 +1247,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (pkt_dev->src_mac_count != value) {
    		pkt_dev->src_mac_count = value;
    		pkt_dev->cur_src_mac_offset = 0;
@@ -1277,7 +1261,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (pkt_dev->dst_mac_count != value) {
    		pkt_dev->dst_mac_count = value;
    		pkt_dev->cur_dst_mac_offset = 0;
@@ -1292,7 +1275,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if ((value > 1) &&
    	    ((pkt_dev->xmit_mode == M_QUEUE_XMIT) ||
    	     ((pkt_dev->xmit_mode == M_START_XMIT) &&
@@ -1312,8 +1294,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
-
    	if (node_possible(value)) {
    		pkt_dev->node = value;
    		sprintf(pg_result, "OK: node=%d", pkt_dev->node);
@@ -1337,7 +1317,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	memset(f, 0, sizeof(f));
    	if (copy_from_user(f, &user_buffer[i], len))
    		return -EFAULT;
-		i += len;
if (strcmp(f, "start_xmit") == 0) {
    		pkt_dev->xmit_mode = M_START_XMIT;
@@ -1378,7 +1357,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	memset(f, 0, 32);
    	if (copy_from_user(f, &user_buffer[i], len))
    		return -EFAULT;
-		i += len;
flag = pktgen_read_flag(f, &disable);
    	if (flag) {
@@ -1436,7 +1414,7 @@ static ssize_t pktgen_if_write(struct file *file,
    	}
    	if (debug)
    		pr_debug("dst_min set to: %s\n", pkt_dev->dst_min);
-		i += len;
+
    	sprintf(pg_result, "OK: dst_min=%s", pkt_dev->dst_min);
    	return count;
    }
@@ -1457,7 +1435,7 @@ static ssize_t pktgen_if_write(struct file *file,
    	}
    	if (debug)
    		pr_debug("dst_max set to: %s\n", pkt_dev->dst_max);
-		i += len;
+
    	sprintf(pg_result, "OK: dst_max=%s", pkt_dev->dst_max);
    	return count;
    }
@@ -1481,7 +1459,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (debug)
    		pr_debug("dst6 set to: %s\n", buf);
-		i += len;
    	sprintf(pg_result, "OK: dst6=%s", buf);
    	return count;
    }
@@ -1504,7 +1481,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (debug)
    		pr_debug("dst6_min set to: %s\n", buf);
-		i += len;
    	sprintf(pg_result, "OK: dst6_min=%s", buf);
    	return count;
    }
@@ -1526,7 +1502,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (debug)
    		pr_debug("dst6_max set to: %s\n", buf);
-		i += len;
    	sprintf(pg_result, "OK: dst6_max=%s", buf);
    	return count;
    }
@@ -1550,7 +1525,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (debug)
    		pr_debug("src6 set to: %s\n", buf);
-		i += len;
    	sprintf(pg_result, "OK: src6=%s", buf);
    	return count;
    }
@@ -1571,7 +1545,7 @@ static ssize_t pktgen_if_write(struct file *file,
    	}
    	if (debug)
    		pr_debug("src_min set to: %s\n", pkt_dev->src_min);
-		i += len;
+
    	sprintf(pg_result, "OK: src_min=%s", pkt_dev->src_min);
    	return count;
    }
@@ -1592,7 +1566,7 @@ static ssize_t pktgen_if_write(struct file *file,
    	}
    	if (debug)
    		pr_debug("src_max set to: %s\n", pkt_dev->src_max);
-		i += len;
+
    	sprintf(pg_result, "OK: src_max=%s", pkt_dev->src_max);
    	return count;
    }
@@ -1645,7 +1619,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (value > MAX_CFLOWS)
    		value = MAX_CFLOWS;
@@ -1660,7 +1633,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	pkt_dev->spi = value;
    	sprintf(pg_result, "OK: spi=%u", pkt_dev->spi);
    	return count;
@@ -1672,7 +1644,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	pkt_dev->lflow = value;
    	sprintf(pg_result, "OK: flowlen=%u", pkt_dev->lflow);
    	return count;
@@ -1684,7 +1655,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	pkt_dev->queue_map_min = value;
    	sprintf(pg_result, "OK: queue_map_min=%u", pkt_dev->queue_map_min);
    	return count;
@@ -1696,7 +1666,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	pkt_dev->queue_map_max = value;
    	sprintf(pg_result, "OK: queue_map_max=%u", pkt_dev->queue_map_max);
    	return count;
@@ -1709,7 +1678,7 @@ static ssize_t pktgen_if_write(struct file *file,
    	len = get_labels(&user_buffer[i], max, pkt_dev);
    	if (len < 0)
    		return len;
-		i += len;
+
    	cnt = sprintf(pg_result, "OK: mpls=");
    	for (n = 0; n < pkt_dev->nr_labels; n++)
    		cnt += sprintf(pg_result + cnt,
@@ -1732,7 +1701,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (value <= 4095) {
    		pkt_dev->vlan_id = value;  /* turn on VLAN */
@@ -1760,7 +1728,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if ((value <= 7) && (pkt_dev->vlan_id != 0xffff)) {
    		pkt_dev->vlan_p = value;
    		sprintf(pg_result, "OK: vlan_p=%u", pkt_dev->vlan_p);
@@ -1776,7 +1743,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if ((value <= 1) && (pkt_dev->vlan_id != 0xffff)) {
    		pkt_dev->vlan_cfi = value;
    		sprintf(pg_result, "OK: vlan_cfi=%u", pkt_dev->vlan_cfi);
@@ -1792,7 +1758,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if ((value <= 4095) && ((pkt_dev->vlan_id != 0xffff))) {
    		pkt_dev->svlan_id = value;  /* turn on SVLAN */
@@ -1820,7 +1785,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if ((value <= 7) && (pkt_dev->svlan_id != 0xffff)) {
    		pkt_dev->svlan_p = value;
    		sprintf(pg_result, "OK: svlan_p=%u", pkt_dev->svlan_p);
@@ -1836,7 +1800,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if ((value <= 1) && (pkt_dev->svlan_id != 0xffff)) {
    		pkt_dev->svlan_cfi = value;
    		sprintf(pg_result, "OK: svlan_cfi=%u", pkt_dev->svlan_cfi);
@@ -1854,7 +1817,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (len == 2) {
    		pkt_dev->tos = tmp_value;
    		sprintf(pg_result, "OK: tos=0x%02x", pkt_dev->tos);
@@ -1872,7 +1834,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	if (len == 2) {
    		pkt_dev->traffic_class = tmp_value;
    		sprintf(pg_result, "OK: traffic_class=0x%02x", pkt_dev->traffic_class);
@@ -1888,7 +1849,6 @@ static ssize_t pktgen_if_write(struct file *file,
    	if (len < 0)
    		return len;
-		i += len;
    	pkt_dev->skb_priority = value;
    	sprintf(pg_result, "OK: skb_priority=%i",
    		pkt_dev->skb_priority);
@@ -2005,7 +1965,7 @@ static ssize_t pktgen_thread_write(struct file *file,
    	}
    	if (copy_from_user(f, &user_buffer[i], len))
    		return -EFAULT;
-		i += len;
+
    	mutex_lock(&pktgen_thread_lock);
    	ret = pktgen_add_device(t, f);
    	mutex_unlock(&pktgen_thread_lock);
-- 
2.48.1


    

2025

2024

2023

2022

2021

2020

2019

2018

2017

[PATCH net-next v6 7/8] net: pktgen: remove all superfluous index assignements