Re: [PATCH net] selftests/bpf: fix pointer arithmetic in test_xdp_do_redirect

Hello:

This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko andrii@kernel.org:

On Mon, 6 May 2024 16:50:22 +0200 you wrote:

Cast operation has a higher precedence than addition. The code here wants to zero the 2nd half of the 64-bit metadata, but due to a pointer arithmetic mistake, it writes the zero at offset 16 instead.

Just adding parentheses around "data + 4" would fix this, but I think this will be slightly better readable with array syntax.

[...]

Here is the summary with links: - [net] selftests/bpf: fix pointer arithmetic in test_xdp_do_redirect https://git.kernel.org/bpf/bpf-next/c/e549b39a0ab8

You are awesome, thank you!