Hi Jakub,
On Thu, May 09, 2024 at 04:55:53PM -0700, Jakub Kicinski wrote:
Vladimir said when adding this test:
The bridge driver fares particularly badly [...] mainly because it does not implement IFF_UNICAST_FLT.
See commit 90b9566aa5cd ("selftests: forwarding: add a test for local_termination.sh").
We don't want to hide the known gaps, but having a test which always fails prevents us from catching regressions. Report the cases we know may fail as XFAIL.
Signed-off-by: Jakub Kicinski kuba@kernel.org
CC: vladimir.oltean@nxp.com CC: shuah@kernel.org CC: petrm@nvidia.com CC: liuhangbin@gmail.com CC: bpoirier@nvidia.com CC: linux-kselftest@vger.kernel.org
tools/testing/selftests/net/forwarding/lib.sh | 9 ++++++++ .../net/forwarding/local_termination.sh | 21 ++++++++++++++----- 2 files changed, 25 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh index 3353a1745946..4fe28ab5d8b9 100644 --- a/tools/testing/selftests/net/forwarding/lib.sh +++ b/tools/testing/selftests/net/forwarding/lib.sh @@ -605,6 +605,15 @@ log_test_xfail() RET=$ksft_xfail retmsg= log_test "$@" } +log_test_xfail() +{
- local test_name=$1
- local opt_str=$2
- printf "TEST: %-60s [XFAIL]\n" "$test_name $opt_str"
- return 0
+}
I may missed something, I saw there is already a log_test_xfail() in lib.sh
log_test_skip() { RET=$ksft_skip retmsg= log_test "$@" }
log_test_xfail() { RET=$ksft_xfail retmsg= log_test "$@" }
log_info() { ... }
Added by a923af1ceee7 ("selftests: forwarding: Convert log_test() to recognize RET values")
Thanks Hangbin