On Mon, Nov 07, 2022 at 10:28:13AM +0800, Aaron Lu wrote:
Hi Greg,
Thanks for taking a look.
On Sun, Nov 06, 2022 at 12:27:12PM +0100, Greg KH wrote:
On Sun, Nov 06, 2022 at 06:19:39PM +0800, Aaron Lu wrote:
To capture potential programming errors like mistakenly setting Global bit on kernel page table entries, a selftest for meltdown is added.
This selftest is based on https://github.com/IAIK/meltdown. What this test does is to firstly set a predefined string at a random user address and then with pagemap, get the physical address of this string. Finally, try to fetch the data using kernel's directmap address for this physical address to see if user space can use kernel's page table.
As this is based on someone else's code, what happened to the proper credit for them as the author and copyright owner?
Should I list the contributors in the patch header comment section? Something like this:
The original code is contributed by: $ git shortlog -sne --all 24 Michael Schwarz michael.schwarz91@gmail.com 23 Michael Schwarz michael.schwarz@student.tugraz.at 9 Pavel Boldin boldin.pavel@gmail.com 6 Daniel Gruss lava@gruss.cc 3 Daniel Gruss daniel.gruss@iaik.tugraz.at 3 Jared Deckard jdeckard@equityins.net 3 Moritz Lipp github@mlq.me 2 Matteo Croce mcroce@redhat.com 2 Raphael Carvalho raphael.scarv@gmail.com 2 asgh asgh@users.noreply.github.com 1 Eduardo Marques eduardorbmarques@gmail.com 1 Egor Vorontsov sdoregor@sdore.me 1 Jakub Wilk jwilk@jwilk.net 1 Jason Davies jason@jasondavies.com 1 Lukasz Gryglicki lukaszgryglicki@o2.pl 1 Michael Schwarz michael.schwarz@iaik.tugraz.at 1 Raphael S. Carvalho raphaelsc@scylladb.com 1 Steven steven@ceriously.com 1 Vamsi Krishna vamsi3@outlook.com 1 pierwill 19642016+pierwill@users.noreply.github.com 1 ysiyer yegnesh.s.iyer@intel.com
As for copyright, the only copyright I can find in the referenced repo is in the LICENSE file and it is: Copyright (c) 2018 meltdown, I'm not sure if I'm allowed to add copyright statement for others.
Again, please work with your lawyers so that they can give you the correct legal advice, one that they are comfortable having a patch with a signed-off-by from an Intel employee to have.
So next time you submit this, please have an Intel lawyer on the signed-off-by chain so that we know it is meeting their rules.
thanks,
greg k-h