On 17/01/20 11:32 pm, Dave Hansen wrote:
I also tested the series. The 64-bit binary works fine. But,
This is failing to build the x86 selftests:
make: *** No rule to make target 'protection_keys.c', needed by '/home/daveh/linux/tools/testing/selftests/x86/protection_keys_32'. Stop.
I think you just forgot to remove the binary from the x86 Makefile.
Which reminds me: This removes the 32-bit binary. x86 32-bit binaries exercise different paths than the 64-bit ones, so we like to have both. Although it isn't *essential* it would really be nice to keep the 32-bit binary.
Oops. Let me fix that. Thanks for testing this.
- Sandipan