On 2024/2/8 16:53, Tian, Kevin wrote:
From: Liu, Yi L yi.l.liu@intel.com Sent: Thursday, February 8, 2024 4:23 PM
@@ -4760,6 +4790,12 @@ static int intel_iommu_set_dirty_tracking(struct iommu_domain *domain, if (ret) goto err_unwind;
- if (dmar_domain->nested_parent) {
ret = parent_domain_set_dirty_tracking(dmar_domain,
enable);
if (ret)
goto err_unwind;
- }
there also lack of setting dirty tracking when a device is attached to the nested domain while the parent already has dirty-tracking enabled.
but looks even w/o nesting this is missed in the attach path.
could be fixed separately. so for this one:
it's fixed here. https://lore.kernel.org/linux-iommu/20240208091414.28133-1-yi.l.liu@intel.co...
Reviewed-by: Kevin Tian kevin.tian@intel.com